core: Report marshaller error for uncompressed size too large back to the client 2 #12477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e back to the client " This reverts commit 7eab160.
panchenko
changed the title
panchenko
commented
Nov 6, 2025
| private void handleParseError(StatusRuntimeException parseError) { | ||
| cancelled = true; | ||
| log.log(Level.WARNING, "Cancelling the stream because of parse error", parseError); | ||
| stream.cancel(parseError.getStatus().withCause(new CloseWithHeadersMarker())); |
There was a problem hiding this comment.
This can be made more obvious with some API changes
kannanjgithub
approved these changes
Nov 6, 2025
kannanjgithub
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11246
code mostly as in #12360 but trying to use
handleInternalError()/cancel()as suggested by @ejona86