Skip to content

Conversation

@duelinmarkers
Copy link
Contributor

@duelinmarkers duelinmarkers commented Aug 23, 2017

In 72b9ee2 (see also #3328, #3338), gson kept its old name while opencensus got what should have
become gson's new name instead of a fixed opencensus name.

I think this resolves that.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@duelinmarkers
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

In 72b9ee2, gson kept its old name while opencensus got what should have
become gson's new name instead of a fixed opencensus name.
@duelinmarkers duelinmarkers force-pushed the fix-gson-opencensus-naming-mixup branch from 39ca2ac to 957130c Compare August 23, 2017 20:03
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tehehe. Oops.

@ejona86
Copy link
Member

ejona86 commented Aug 23, 2017

Okay to test

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 23, 2017
@kokoro-team kokoro-team removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 23, 2017
@ejona86 ejona86 merged commit 7d0229a into grpc:master Aug 23, 2017
@duelinmarkers
Copy link
Contributor Author

Could we have 5c902c9 and 7d0229a cherry-picked onto the v1.6.x branch so the first 1.6 release will be useable from bazel projects conveniently? I can submit a PR for this if it would be helpful. Thanks.

@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Aug 28, 2017
@ejona86
Copy link
Member

ejona86 commented Aug 28, 2017

@duelinmarkers, yeah, I think it makes sense to backport them. I've added the backport label for us to backport them before the release.

@pgr0ss
Copy link
Contributor

pgr0ss commented Aug 28, 2017

Thanks @duelinmarkers for fixing my mistake. Looks I screwed up my scripting for bulk updating.

@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Aug 28, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants