-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix gson / opencensus bazel naming mixup #3379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gson / opencensus bazel naming mixup #3379
Conversation
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
In 72b9ee2, gson kept its old name while opencensus got what should have become gson's new name instead of a fixed opencensus name.
39ca2ac to
957130c
Compare
ejona86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tehehe. Oops.
|
Okay to test |
|
@duelinmarkers, yeah, I think it makes sense to backport them. I've added the backport label for us to backport them before the release. |
|
Thanks @duelinmarkers for fixing my mistake. Looks I screwed up my scripting for bulk updating. |
In 72b9ee2 (see also #3328, #3338), gson kept its old name while opencensus got what should have
become gson's new name instead of a fixed opencensus name.
I think this resolves that.