netty: separate connection log #3591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-kwong
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
matt-kwong
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
zpencer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
| * The Netty-based server transport. | ||
| */ | ||
| class NettyServerTransport implements ServerTransport { | ||
| private static final Logger log = Logger.getLogger(NettyServerTransport.class.getName()); |
Contributor
There was a problem hiding this comment.
Is the original log being used anymore after the change?
Contributor
Author
There was a problem hiding this comment.
I want to have both so it's more obvious to developers in the future that there's a difference between them.
Contributor
There was a problem hiding this comment.
Then you might comment on the two fields what they are used for, and maybe add @SuppressWarnings("unused") to the first one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move netty connection log info to a separate logger:
io.grpc.netty.NettyServerTransport.connections
Users can redirect or disable this log using the usual way:
-Djava.util.logging.config.file="logging.properties"
Related to #1768, #3575