Skip to content

netty: separate connection log #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2017
Merged

netty: separate connection log #3591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b864543
netty: separate connection log
zpencer Oct 19, 2017
2cb4a4e
@SuppressWarning and add comment
zpencer Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion netty/src/main/java/io/grpc/netty/NettyServerTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@
* The Netty-based server transport.
*/
class NettyServerTransport implements ServerTransport {
@SuppressWarnings("unused") // log is for general messages, but nothing currently uses it
private static final Logger log = Logger.getLogger(NettyServerTransport.class.getName());
// connectionLog is for connection related messages only
private static final Logger connectionLog = Logger.getLogger(
String.format("%s.connections", NettyServerTransport.class.getName()));
// Some exceptions are not very useful and add too much noise to the log
private static final ImmutableList<String> QUIET_ERRORS = ImmutableList.of(
"Connection reset by peer",
Expand Down Expand Up @@ -156,7 +160,7 @@ static Level getLogLevel(Throwable t) {

private void notifyTerminated(Throwable t) {
if (t != null) {
log.log(getLogLevel(t), "Transport failed", t);
connectionLog.log(getLogLevel(t), "Transport failed", t);
}
if (!terminated) {
terminated = true;
Expand Down