core: set sampled for local span per MethodDescriptor. #3627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves away from the global String-based Span name registry which is not as flexible as we desire. Also renamed the option name to be more accurate. This is not API-breaking because the origianl addition to MethodDescriptor and code-gen didn't make it into the 1.7.0 release. This is using a snapshot of opencensus, and needs to switch to a release before merging.
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Contributor
Author
|
Resolves #3359 |
zhangkun83
changed the title
Contributor
Author
|
Retest this please |
ejona86
approved these changes
Oct 27, 2017
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
setSampledToLocalTracing is a bit of an awkward name, but I don't have any better suggestion.
bogdandrutu
approved these changes
Oct 31, 2017
Contributor
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
Release is happening tomorrow for OpenCensus.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves away from the global String-based Span name registry which
is not as flexible as we desire.
Also renamed the option name to be more accurate. This is not
API-breaking because the origianl addition to MethodDescriptor and
code-gen didn't make it into the 1.7.0 release.
This is using a snapshot of opencensus, and needs to switch to a
release before merging.