core: no ProxyDetector for GAE+JDK7 #3677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
added
the
TODO:backport
ejona86
approved these changes
Nov 7, 2017
Contributor
Author
|
I do not see the proxy detector changes in 1.7.x so it's only 1.8.x that needs the backport. |
ejona86
removed
the
TODO:backport
zpencer
added a commit
to zpencer/grpc-java
that referenced
this pull request
Nov 10, 2017
zpencer
added a commit
that referenced
this pull request
Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround of the security restrictions, but effectively turns off proxy support in GAE+JDK7.
I can't seem to get AccessController to work in GAE, the checkPermission API fails:
And doPriviledged also fails:
Let's use the usual technique of checking for the
IS_RESTRICTED_APPENGINEflag.Fixes #3676