core: backport pull #3677 to v1.8.x #3711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * A proxy detector that always claims no proxy is needed. | ||
| */ |
Contributor
There was a problem hiding this comment.
optional:
this only appears to be used in tests. You might consider pulling this out into its own static class, putting the instance inside of it, and referencing it from tests like that.
Then the regular code won't have to initialize this anonymous class in prod code.
Contributor
Author
There was a problem hiding this comment.
This is no longer true because GAE+jdk7 will use this noop detector.
zpencer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3677