core: Use hard-coded string for version #3858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using META-INF for loading the version is broken on Android and frequently broken when gRPC is shaded. Having hard-coded strings be replaced on version bumps has been working well. Fixes grpc#2098
| public static final Splitter ACCEPT_ENCODING_SPLITTER = Splitter.on(',').trimResults(); | ||
|
|
||
| private static final String IMPLEMENTATION_VERSION = getImplementationVersion(); | ||
| private static final String IMPLEMENTATION_VERSION = "1.9.0-SNAPSHOT"; // CURRENT_GRPC_VERSION |
Contributor
There was a problem hiding this comment.
according to Package, the version needs to be numerics and dots, no snapshot version.
Member
Author
There was a problem hiding this comment.
What is the implication?
zhangkun83
approved these changes
Dec 12, 2017
xuwei-k
reviewed
Jan 15, 2018
| private static String getImplementationVersion() { | ||
| String version = GrpcUtil.class.getPackage().getImplementationVersion(); | ||
| if (version != null) { | ||
| return "/" + version; |
Contributor
There was a problem hiding this comment.
missing "/" ?
grpc-java-netty/1.8.0 => grpc-java-netty1.9.0
https://github.com/grpc/grpc/blob/v1.8.4/doc/PROTOCOL-HTTP2.md#user-agents
User-Agent → "grpc-" Language ?("-" Variant) "/" Version ?( " (" *(AdditionalProperty ";") ")" )
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using META-INF for loading the version is broken on Android and
frequently broken when gRPC is shaded. Having hard-coded strings be
replaced on version bumps has been working well.
Fixes #2098