Skip to content

core: Use hard-coded string for version #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2017
Merged

core: Use hard-coded string for version #3858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ $ MAJOR=1 MINOR=7 PATCH=0 # Set appropriately for new release
$ VERSION_FILES=(
build.gradle
android-interop-testing/app/build.gradle
core/src/main/java/io/grpc/internal/GrpcUtil.java
examples/build.gradle
examples/pom.xml
examples/android/helloworld/app/build.gradle
Expand Down
10 changes: 1 addition & 9 deletions core/src/main/java/io/grpc/internal/GrpcUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public byte[] parseAsciiString(byte[] serialized) {

public static final Splitter ACCEPT_ENCODING_SPLITTER = Splitter.on(',').trimResults();

private static final String IMPLEMENTATION_VERSION = getImplementationVersion();
private static final String IMPLEMENTATION_VERSION = "1.9.0-SNAPSHOT"; // CURRENT_GRPC_VERSION
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to Package, the version needs to be numerics and dots, no snapshot version.

Copy link
Member Author

@ejona86 ejona86 Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the implication?


/**
* The default delay in nanos before we send a keepalive.
Expand Down Expand Up @@ -736,12 +736,4 @@ static <T> boolean iterableContains(Iterable<T> iterable, T item) {
}

private GrpcUtil() {}

private static String getImplementationVersion() {
String version = GrpcUtil.class.getPackage().getImplementationVersion();
if (version != null) {
return "/" + version;
Copy link
Contributor

@xuwei-k xuwei-k Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "/" ?

grpc-java-netty/1.8.0 => grpc-java-netty1.9.0

https://github.com/grpc/grpc/blob/v1.8.4/doc/PROTOCOL-HTTP2.md#user-agents

User-Agent → "grpc-" Language ?("-" Variant) "/" Version ?( " (" *(AdditionalProperty ";") ")" )

Copy link
Member Author

@ejona86 ejona86 Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 Sent out #3974

}
return "";
}
}