Skip to content

Marking GrpcServerRule as final #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2018
Merged

Marking GrpcServerRule as final #4264

merged 1 commit into from
Mar 23, 2018

Conversation

@amitdesai03
Copy link
Contributor

@amitdesai03 amitdesai03 commented Mar 23, 2018

No description provided.

@thelinuxfoundation
Copy link

thelinuxfoundation commented Mar 23, 2018

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@amitdesai03
Copy link
Contributor Author

amitdesai03 commented Mar 23, 2018

Issue Reference: #4239

@amitdesai03
Copy link
Contributor Author

amitdesai03 commented Mar 23, 2018

oops, my email id was not referenced in this github account, corrected

@amitdesai03
Copy link
Contributor Author

amitdesai03 commented Mar 23, 2018

Signed CLA

carl-mastrangelo
carl-mastrangelo approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapengzhang0 Want to merge?

@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 23, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 23, 2018
@dapengzhang0
Copy link
Contributor

dapengzhang0 commented Mar 23, 2018

LGTM

@dapengzhang0 dapengzhang0 merged commit 8fe313f into grpc:master Mar 23, 2018
@dapengzhang0
Copy link
Contributor

dapengzhang0 commented Mar 23, 2018

@amitdesai03 Thank you for the fix!

@dapengzhang0 dapengzhang0 added this to the 1.12 milestone Mar 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@carl-mastrangelo carl-mastrangelo carl-mastrangelo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Type: API Change

Projects

None yet

Milestone

1.12

Development

Successfully merging this pull request may close these issues.

5 participants

@amitdesai03 @thelinuxfoundation @dapengzhang0 @carl-mastrangelo @kokoro-team