services: set the default serving state of all services to SERVING#5274
services: set the default serving state of all services to SERVING#5274carl-mastrangelo merged 1 commit intogrpc:masterfrom
Conversation
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Should there be a documentation update?
|
Filed grpc/grpc#17805 |
|
This seems incorrect to me. We should not set any service other than the empty string to SERVING by default. None of the other languages do that. |
|
@markdroth, @carl-mastrangelo, I was meaning in the Javadoc. |
|
Ah, okay. Carry on, then. :) |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
Added a comment. |
| * {@link #getHealthService()} method. | ||
| * The health status manager can update the health statuses of the server. | ||
| * | ||
| * <p> |
There was a problem hiding this comment.
What's with this formatting? Don't intent because of the <p>. Don't include the </p>. End in a period.
* <p>The default, empty-string, service name, {@link #SERVICE_NAME_ALL_SERVICES}, is initialized to
* {@link ServingStatus#SERVING}.
There was a problem hiding this comment.
It's what IntelliJ likes. Seems arbitrary.
| * The health status manager can update the health statuses of the server. | ||
| * | ||
| * <p>The default, empty-string, service name, {@link #SERVICE_NAME_ALL_SERVICES}, is initialized to | ||
| * {@link ServingStatus#SERVING}. |
There was a problem hiding this comment.
Remove the extra indentation here as well.
It's part of the style guide. https://google.github.io/styleguide/javaguide.html#s7.1.2-javadoc-paragraphs
carl-mastrangelo
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
4 participants
No description provided.