Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: introduce NameResolver.Helper and deprecate the params on newNameResolver() #5345

merged 9 commits into from Feb 12, 2019


Copy link

commented Feb 11, 2019

Context: #4159 (comment)

Attributes is appropriate for plumbing optional objects, especially useful for a long plumbing path where components in the middle may not care or see all objects in the container. It's not the case for the params on newNewResolver(). Both the default port and the proxy detector are guaranteed to be there and the plumbing path is very short. In this case, a first-class object is more appropriate and easier to use.

The Helper will also have getSynchronizationContext() (#2649) and a method to parse and validate service config. We we also considering merging Listener into the Helper, to make NameResolver match the LoadBalancer API.

zhangkun83 added 8 commits Jan 7, 2019

@zhangkun83 zhangkun83 requested a review from ejona86 Feb 11, 2019

@zhangkun83 zhangkun83 merged commit e875a8c into grpc:master Feb 12, 2019

10 checks passed

Android Kokoro build finished
Bazel Kokoro build finished
GAE Interop Kokoro build finished
Linux artifacts Kokoro build finished
Macos Kokoro build finished
Windows Kokoro build finished
android/apk_diff New APK size in bytes: 1,011,037 (delta: 64)
android/dex_diff New DEX reference count: 12,703 (delta: 6)
cla/linuxfoundation zhangkun83 authorized
continuous-integration/travis-ci/pr The Travis CI build passed

@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
2 participants
You can’t perform that action at this time.