xds: integrate usage of XdsClient in XdsNameResolver #6504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidzcy
force-pushed
the
impl/instantiate_xds_client_in_xds_resolver
branch
from
b7e4ce6 to
4e933a1
Compare
voidzcy
force-pushed
the
impl/instantiate_xds_client_in_xds_resolver
branch
from
4e933a1 to
2596d97
Compare
voidzcy
force-pushed
the
impl/instantiate_xds_client_in_xds_resolver
branch
from
2596d97 to
8594106
Compare
voidzcy
force-pushed
the
impl/instantiate_xds_client_in_xds_resolver
branch
from
ef6af6e to
10eec0c
Compare
dapengzhang0
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
LGTM
@ericgribkoff Can you please run a staging test to see if it works before merging? With this PR the full XdsNameResolver -> LDS -> RDS -> CDS -> EDS flow will run. Previously only XdsNameresolver -> EDS.
dapengzhang0
added a commit
that referenced
this pull request
Jan 8, 2020
Incorporating comment #6504 (comment). Currently there is no cross-language resolver sending CDS config so there is no impact of the change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
XdsNameResolverstarts, it instantiate anXdsClientinstance to send out an xDS discovery RPC resolving cluster name for gRPC target. When a result found, return aResolutionResultwith service config containingcds_experimentalas the load balancing config to the channel. The instantiatedXdsClientinstance is also passed as anResolutionResult.Attributesto channel.