xds: XdsClient support for hashing based load balancing #7859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidzcy
changed the title
…xds_client_ring_hash_lb_config
voidzcy
force-pushed
the
impl/support_xds_client_ring_hash_lb_config
branch
from
1559dbf to
70e6564
Compare
voidzcy
force-pushed
the
impl/support_xds_client_ring_hash_lb_config
branch
from
d7b7b43 to
22cdc11
Compare
|
Ping. |
dapengzhang0
approved these changes
Feb 11, 2021
| return; | ||
| } | ||
| String endpointPickingPolicy = root.result.lbPolicy; | ||
| String endpointPickingPolicy = root.result.lbPolicy(); |
There was a problem hiding this comment.
In case of ring_hash, endpointPickingPolicy should be appended with _experimental.
new PolicySelection(endpointPickingLbProvider, null) should not pass a non-null config.
It's fine if you do it when implementing the balancer.
…xds_client_ring_hash_lb_config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two parts to XdsClient for receiving configurations that support hashing based load balancing policies:
Routecontains a list ofHashPolicys, which specifies the hash value generation for requests routed to that Route.Clusterresource can specify lb policy other than "round_robin" (which is the only one we support nowadays). If it is "ring_hash", it contains the configuration for mapping each RPC's hash value to one of the endpoints.