Remove Headers in favor of Metadata#822
Merged
carl-mastrangelo merged 1 commit intogrpc:masterfrom Aug 24, 2015
Merged
Conversation
carl-mastrangelo
force-pushed
the
guillotine
branch
from
74eb02d to
34c43c0
Compare
Member
There was a problem hiding this comment.
Just delete, we have no need for path, at least not yet.
Contributor
Author
There was a problem hiding this comment.
@ejona This is a behavior change and thus an API breakage. (Client provided headers will override the method name). Are you sure you want this?
Member
There was a problem hiding this comment.
@carl-mastrangelo, are you thinking we should keep it, or preferring to delete it?
|
LGTM |
Member
carl-mastrangelo
force-pushed
the
guillotine
branch
from
113e07b to
87de976
Compare
Contributor
Author
|
Friendly ping |
Member
|
The rebase means I don't know what changed. I'll have to do a full new review. |
Contributor
Author
|
@ejona86 PTAL |
Member
|
@carl-mastrangelo LGTM |
carl-mastrangelo
force-pushed
the
guillotine
branch
from
f35ff9c to
828525f
Compare
carl-mastrangelo
force-pushed
the
guillotine
branch
from
828525f to
a508c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649