Skip to content

Conversation

@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Sep 13, 2018

Fixes #545.

Since getRequestMetadata is now deprecated in google-auth-library, we are getting deprecation warnings in Google Cloud client libraries.

Since there is no good way to tell if the user passed old or new googleCredentials object, we can check if it has getRequestHeaders method or not, and if it has one, use it, otherwise fallback to the old getRequestMetadata. Ugly but works.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@alexander-fenster
Copy link
Contributor Author

I signed it

@alexander-fenster
Copy link
Contributor Author

As discussed today, please release the patch release with this change if possible. Since google-gax requires "grpc": "^1.12.2", the change will be picked up by client libraries automatically. Thanks!

@nicolasnoble nicolasnoble changed the base branch from master to grpc@1.15.x September 13, 2018 23:01
@nicolasnoble nicolasnoble changed the base branch from grpc@1.15.x to master September 13, 2018 23:01
@nicolasnoble
Copy link
Contributor

We'll have to cherry-pick it for 1.15.

@JustinBeckwith
Copy link
Contributor

Thanks folks. When do you expect 1.15 to land?

@nicolasnoble
Copy link
Contributor

We'll likely do a 1.15.1 tomorrow since this is the only change.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants