-
Notifications
You must be signed in to change notification settings - Fork 682
grpc-native-core: do not use deprecated getRequestMetadata #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-native-core: do not use deprecated getRequestMetadata #547
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
I signed it |
|
As discussed today, please release the patch release with this change if possible. Since |
|
We'll have to cherry-pick it for 1.15. |
|
Thanks folks. When do you expect 1.15 to land? |
|
We'll likely do a 1.15.1 tomorrow since this is the only change. |
Fixes #545.
Since
getRequestMetadatais now deprecated ingoogle-auth-library, we are getting deprecation warnings in Google Cloud client libraries.Since there is no good way to tell if the user passed old or new
googleCredentialsobject, we can check if it hasgetRequestHeadersmethod or not, and if it has one, use it, otherwise fallback to the oldgetRequestMetadata. Ugly but works.