Skip to content

Handle parse failures when merging test logs #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2019
Merged

Handle parse failures when merging test logs #867

merged 1 commit into from
May 16, 2019

Conversation

@murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented May 15, 2019

This should fix the problem we see in the test logs in #864 where some parsed logs were null and that stopped it from combining other logs for the same Node version.

@murgatroid99 murgatroid99 requested a review from nicolasnoble May 15, 2019 22:38
@murgatroid99 murgatroid99 merged commit 1d1d2b9 into grpc:master May 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@murgatroid99 @nicolasnoble