Fix watchOS availability guard for Network.framework TLS #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In grpc#1221 we added Network.framework as a provider for TLS. However in a few places we incorrectly set the availability for watchOS as 5.0. It should be 6.0 (as required by NIOTS). If the watchOS deployment target was set to 5.0 then the build would result in a number of errors (as the availability requirements for using various NIOTS types would not be sufficient). Modifications: - Raise the availability version for various APIs which use Network.framework Result: No build errors for types which aren't availabile on watchOS 5.0.
Lukasa
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #1221 we added Network.framework as a provider for TLS. However in a
few places we incorrectly set the availability for watchOS as 5.0. It
should be 6.0 (as required by NIOTS).
If the watchOS deployment target was set to 5.0 then the build would
result in a number of errors (as the availability requirements for using
various NIOTS types would not be sufficient).
Modifications:
Result:
No build errors for types which aren't availabile on watchOS 5.0.
Credit to @cpriebe for spotting this.