Update compiler guards for concurrency #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The 'right' way to check if Swift concurrency is available is to use `#if compiler(>=5.5) && canImport(_Concurrency)`. We are missing currently missing the `canImport` check. Modifications: Add check for `canImport(_Concurrency)`. Results: We more correctly check whether concurrency is available.
Lukasa
approved these changes
Sep 27, 2021
glbrntt
added a commit
that referenced
this pull request
Nov 26, 2021
Motivation: The 'right' way to check if Swift concurrency is available is to use `#if compiler(>=5.5) && canImport(_Concurrency)`. We are missing currently missing the `canImport` check. Modifications: Add check for `canImport(_Concurrency)`. Results: We more correctly check whether concurrency is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The 'right' way to check if Swift concurrency is available is to use
#if compiler(>=5.5) && canImport(_Concurrency). We are missingcurrently missing the
canImportcheck.Modifications:
Add check for
canImport(_Concurrency).Results:
We more correctly check whether concurrency is available.