Drop user context when closing client interceptor pipeline #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Interceptor pipelines hold arrays of interceptor contexts. Each context maintains a reference back to the pipeline. However the client interceptor pipeline never broke this reference cycle when closing the pipeline which means that using client interceptors introduces a memory leak. Modifications: - Explicitly remove all user contexts when the client interceptor pipeline is torn down (the server pipeline already does this so is unaffected) - Add allocation tests so we can see the overhead of using interceptors (and, more importantly, whether allocations are freed) Result: Using client interceptors no longer leaks.
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Nov 10, 2021
Motivation: Interceptor pipelines hold arrays of interceptor contexts. Each context maintains a reference back to the pipeline. However the client interceptor pipeline never broke this reference cycle when closing the pipeline which means that using client interceptors introduces a memory leak. Modifications: - Explicitly remove all user contexts when the client interceptor pipeline is torn down (the server pipeline already does this so is unaffected) - Add allocation tests so we can see the overhead of using interceptors (and, more importantly, whether allocations are freed) Result: Using client interceptors no longer leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Interceptor pipelines hold arrays of interceptor contexts. Each context
maintains a reference back to the pipeline. However the client
interceptor pipeline never broke this reference cycle when closing the
pipeline which means that using client interceptors introduces a memory
leak.
Modifications:
torn down (the server pipeline already does this so is unaffected)
(and, more importantly, whether allocations are freed)
Result:
Using client interceptors no longer leaks.