Add a pooled channel #1284
Merged
Add a pooled channel #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I have a follow up PR with some allocation counting tests. |
Lukasa
approved these changes
Sep 30, 2021
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
I have one minor note regarding inlinability but otherwise I think this patch is fantastic, and I'm really excited to have this functionality available in grpc-swift.
| /// Default HTTP/2 configuration. | ||
| public static let defaults = HTTP2() | ||
|
|
||
| public static func with(_ configure: (inout HTTP2) -> Void) -> HTTP2 { |
Collaborator
There was a problem hiding this comment.
All your various with functions here should probably aim to be @inlinable.
glbrntt
force-pushed
the
gb-pooled-client
branch
from
c346fa6 to
027cb1c
Compare
Motivation: We added the various internals of the connection pool but are yet to surface it as public API. This PR does just that. Modifications: - Add a `PooledChannel`, a `GRPCChannel` which uses the connection pool - Add `GRPCPooledChannel` and `GRPCPooledChannel.Configuration` which produces `PooledChannel`s as `GRPCChannel`s. - Add a handful of tests Result: We have a usable connection pool in the public API.
glbrntt
force-pushed
the
gb-pooled-client
branch
from
027cb1c to
c1a0091
Compare
Collaborator
Author
|
Unfortunately we regress 1 alloc per RPC but I think it's worth it since switching to the pooled channel allocates quite a bit less and should be preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We added the various internals of the connection pool but are yet to
surface it as public API. This PR does just that.
Modifications:
PooledChannel, aGRPCChannelwhich uses the connection poolGRPCPooledChannelandGRPCPooledChannel.Configurationwhichproduces
PooledChannels asGRPCChannels.Result:
We have a usable connection pool in the public API.