Skip to content

Remove client didSet state transition check #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Remove client didSet state transition check #1310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 1 addition & 35 deletions Sources/GRPC/GRPCClientStateMachine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,41 +131,7 @@ struct GRPCClientStateMachine {
}

/// The current state of the state machine.
internal private(set) var state: State {
didSet {
switch (oldValue, self.state) {
// Any modifying transitions are fine.
case (.modifying, _),
(_, .modifying):
break

// All valid transitions:
case (.clientIdleServerIdle, .clientActiveServerIdle),
(.clientIdleServerIdle, .clientClosedServerClosed),
(.clientActiveServerIdle, .clientActiveServerActive),
(.clientActiveServerIdle, .clientClosedServerIdle),
(.clientActiveServerIdle, .clientClosedServerClosed),
(.clientClosedServerIdle, .clientClosedServerActive),
(.clientClosedServerIdle, .clientClosedServerClosed),
(.clientActiveServerActive, .clientClosedServerActive),
(.clientActiveServerActive, .clientClosedServerClosed),
(.clientClosedServerActive, .clientClosedServerClosed):
break

// Self transitions, also valid:
case (.clientIdleServerIdle, .clientIdleServerIdle),
(.clientActiveServerIdle, .clientActiveServerIdle),
(.clientClosedServerIdle, .clientClosedServerIdle),
(.clientActiveServerActive, .clientActiveServerActive),
(.clientClosedServerActive, .clientClosedServerActive),
(.clientClosedServerClosed, .clientClosedServerClosed):
break

default:
preconditionFailure("invalid state transition from '\(oldValue)' to '\(self.state)'")
}
}
}
internal private(set) var state: State

/// The default user-agent string.
private static let userAgent = "grpc-swift-nio/\(Version.versionString)"
Expand Down