Remove client didSet state transition check #1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `GRPCClientStateMachine.state` has a `didSet` to validate state transitions. The presence of this block seems to trip up libbacktrace when running with the scudo sanitizer. Moreover, the check is not particularly helpful since we should always be transition to and from the modifying state. This appears to have been leftover from when the modifying state was introduced. This is related to https://bugs.swift.org/browse/SR-15478. Modifications: Remove the didSet block for state in GRPCClientStateMachine. Result: We don't trip over in libbacktrace when running with scudo.
Lukasa
approved these changes
Nov 12, 2021
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Dec 16, 2021
Motivation: `GRPCClientStateMachine.state` has a `didSet` to validate state transitions. The presence of this block seems to trip up libbacktrace when running with the scudo sanitizer. Moreover, the check is not particularly helpful since we should always be transition to and from the modifying state. This appears to have been leftover from when the modifying state was introduced. This is related to https://bugs.swift.org/browse/SR-15478. Modifications: Remove the didSet block for state in GRPCClientStateMachine. Result: We don't trip over in libbacktrace when running with scudo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
GRPCClientStateMachine.statehas adidSetto validate statetransitions. The presence of this block seems to trip up libbacktrace
when running with the scudo sanitizer. Moreover, the check is not
particularly helpful since we should always be transition to and from
the modifying state. This appears to have been leftover from when the
modifying state was introduced.
This is related to https://bugs.swift.org/browse/SR-15478.
Modifications:
Remove the didSet block for state in GRPCClientStateMachine.
Result:
We don't trip over in libbacktrace when running with scudo.