Allow gRPC to be built without NIOSSL #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
gb-can-import-niossl
branch
2 times, most recently
from
cb0efc7 to
d6b3806
Compare
Motivation: In some situations NIOSSL isn't required when using gRPC. Since NIOSSL brings a copy of BoringSSL with it it is quite a large depenency to bring along. Modifications: - Wrap all code which uses NIOSSL in `#if canImport(NIOSSL)` - This required shuffling around a few files, the code isn't meaningfully different otherwise Result: gRPC can be compiled without NIOSSL.
glbrntt
force-pushed
the
gb-can-import-niossl
branch
from
d6b3806 to
b74dceb
Compare
Lukasa
approved these changes
Nov 15, 2021
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - image: swift:5.4-focal |
Collaborator
Author
There was a problem hiding this comment.
Looks like we don't have 5.5 at all. Let's add it in a separate pr.
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Dec 16, 2021
Motivation: In some situations NIOSSL isn't required when using gRPC. Since NIOSSL brings a copy of BoringSSL with it it is quite a large depenency to bring along. Modifications: - Wrap all code which uses NIOSSL in `#if canImport(NIOSSL)` - This required shuffling around a few files, the code isn't meaningfully different otherwise Result: gRPC can be compiled without NIOSSL.
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Jun 17, 2022
Motivation: In some situations NIOSSL isn't required when using gRPC. Since NIOSSL brings a copy of BoringSSL with it it is quite a large depenency to bring along. Modifications: - Wrap all code which uses NIOSSL in `#if canImport(NIOSSL)` - This required shuffling around a few files, the code isn't meaningfully different otherwise Result: gRPC can be compiled without NIOSSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In some situations NIOSSL isn't required when using gRPC. Since NIOSSL
brings a copy of BoringSSL with it it is quite a large depenency to
bring along.
Modifications:
#if canImport(NIOSSL)meaningfully different otherwise
Result:
gRPC can be compiled without NIOSSL.