Deflake zero length write tests #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The zero-length write tests fail every so often because the XCTest expectations are over fulfilled. They can be overfulfilled when the client makes multiple attempts to connect to the test server. This can happen because of happy eyeballs or because the client is re-attempting to connect to the server. Modifications: - Use "127.0.0.1" instead of "localhost" to avoid using happy eyeballs - Disable client connection re-establishment Result: Less flakey test.
Lukasa
approved these changes
Nov 23, 2021
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Dec 16, 2021
Motivation: The zero-length write tests fail every so often because the XCTest expectations are over fulfilled. They can be overfulfilled when the client makes multiple attempts to connect to the test server. This can happen because of happy eyeballs or because the client is re-attempting to connect to the server. Modifications: - Use "127.0.0.1" instead of "localhost" to avoid using happy eyeballs - Disable client connection re-establishment Result: Less flakey test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The zero-length write tests fail every so often because the XCTest
expectations are over fulfilled.
They can be overfulfilled when the client makes multiple attempts to
connect to the test server. This can happen because of happy eyeballs or
because the client is re-attempting to connect to the server.
Modifications:
Result:
Less flakey test.