Propagate request ID for channel pool #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The channel pool currently ignores the request ID call options, meaning that request IDs are not correctly propagated. Modifications: - Apply request ID to call options. Result: - Request ID from call options is propagated to the server in request headers when using a connection pool.
Lukasa
approved these changes
Dec 14, 2021
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Dec 16, 2021
Motivation: The channel pool currently ignores the request ID call options, meaning that request IDs are not correctly propagated. Modifications: - Apply request ID to call options. Result: - Request ID from call options is propagated to the server in request headers when using a connection pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The channel pool currently ignores the request ID call options, meaning
that request IDs are not correctly propagated.
Modifications:
Result:
headers when using a connection pool.