Update the RouteGuide example and tutorial #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Dec 15, 2021
glbrntt
force-pushed
the
gb-update-route-guide
branch
from
61bddc0 to
7d93fd5
Compare
glbrntt
force-pushed
the
gb-update-route-guide
branch
from
7d93fd5 to
3b74c1a
Compare
Motivation: Our examples should be up-to-date. The RouteGuide example currently uses the NIO event-loop-future API, it should use the async/await API instead. Modifications: - Convert the route guide example to async/await - Update the corresponding tutorial Result: RouteGuide is more up-to-date
glbrntt
force-pushed
the
gb-update-route-guide
branch
from
3b74c1a to
4682255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our examples should be up-to-date. The RouteGuide example currently uses
the NIO event-loop-future API, it should use the async/await API
instead.
Modifications:
Result:
RouteGuide is more up-to-date