Skip to content

Create ServerStatus.swift #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timburks merged 1 commit into from
Jul 3, 2018
Merged

Create ServerStatus.swift #261

timburks merged 1 commit into from
Jul 3, 2018

Conversation

@KyoheiG3
Copy link
Contributor

@KyoheiG3 KyoheiG3 commented Jul 3, 2018

ServerStatus should exist in Core because it is called from Handler that is in Core.

MrMage
MrMage approved these changes Jul 3, 2018
View reviewed changes
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@timburks
Copy link
Member

timburks commented Jul 3, 2018

@KyoheiG3 thanks for catching this!

@timburks timburks merged commit c401b44 into grpc:master Jul 3, 2018
@KyoheiG3 KyoheiG3 deleted the server-status branch July 4, 2018 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrMage MrMage MrMage approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KyoheiG3 @timburks @MrMage