Skip to content

Conversation

@acchou
Copy link
Contributor

@acchou acchou commented Mar 21, 2017

Added header search path to the Echo example to allow it to build. Also
added instructions to run the script in the third party directory to
clone the swift-protobuf repo locally, which is required by the Echo
example but not mentioned. Also update the toplevel readme to make the
required make command explicit, and fix the name swift-proto to
swift-protobuf

Added header search path to the Echo example to allow it to build. Also
added instructions to run the script in the third party directory to
clone the swift-protobuf repo locally, which is required by the Echo
example but not mentioned. Also update the toplevel readme to make the
required make command explicit, and fix the name `swift-proto` to
`swift-protobuf`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@acchou
Copy link
Contributor Author

acchou commented Mar 21, 2017

Signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@jcanizales jcanizales requested a review from timburks March 21, 2017 20:30
@timburks
Copy link
Member

Looks good, thanks!

@timburks timburks merged commit 8f9c7ff into grpc:master Mar 21, 2017
@maznikoff maznikoff mentioned this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants