Skip to content

Fix Echo example and improve instructions #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2017
+25 −9
Merged

Fix Echo example and improve instructions #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.DS_Store
project.xcworkspace
xcuserdata
.build
third_party/**
2 changes: 2 additions & 0 deletions Examples/Echo/Xcode/Echo.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
HEADER_SEARCH_PATHS = ../../../Sources/CgRPC/include;
MACOSX_DEPLOYMENT_TARGET = 10.11;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
Expand Down Expand Up @@ -501,6 +502,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
HEADER_SEARCH_PATHS = ../../../Sources/CgRPC/include;
MACOSX_DEPLOYMENT_TARGET = 10.11;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = macosx;
Expand Down
7 changes: 7 additions & 0 deletions Examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@

# Examples

To build the Xcode examples, make sure required third party libraries
(specifically `swift-protobuf`) are retrieved by running the script in the
`third_party` toplevel directory:

$ cd third_party
$ sh RUNME.sh

## Swift gRPC generated code examples

[Echo](Echo)
Expand Down
23 changes: 14 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Swift Package Manager builds may also be made on Linux
systems. Please see [DOCKER.md](DOCKER.md) and
[LINUX.md](LINUX.md) for details.

## gRPC dependencies are vendored
## gRPC dependencies are vendored

Swift gRPC now includes vendored copies of the gRPC core
library and **BoringSSL**, an OpenSSL fork that is used by
Expand All @@ -36,13 +36,18 @@ Manager builds.

## Building with Xcode

The top-level Makefile uses the Swift Package Manager to generate
an Xcode project for the SwiftGRPC package. Due to present limitations
in Package Manager configuration, the libz dependency is not included
in the generated Xcode project. If you get build errors about missing
symbols such as `_deflate`, `_deflateEnd`, etc., you can fix them by
adding `libz.tbd` to the **Link Binary With Libraries** build step of
the **CgRPC** target.
The top-level Makefile uses the Swift Package Manager to
generate an Xcode project for the SwiftGRPC package:

$ make

Then open `SwiftGRPC.xcodeproj` in Xcode. Due to present
limitations in Package Manager configuration, the libz
dependency is not included in the generated Xcode project. If
you get build errors about missing symbols such as
`_deflate`, `_deflateEnd`, etc., you can fix them by adding
`libz.tbd` to the **Link Binary With Libraries** build step
of the **CgRPC** target.

## Having build problems?

Expand All @@ -51,7 +56,7 @@ testing with the following versions:

- Xcode 8.2
- Swift 3.0.2
- swift-proto 0.9.24
- swift-protobuf 0.9.24

## License

Expand Down