Remove unexported executables from products #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: From https://developer.apple.com/documentation/swift_packages/product > Executable > Use an executable product to vend an executable target. > Use this only if you want to make the executable available to clients. Several executable products are not meant to be made available to clients, but rather exist for internal integration or performance tests. Further, most of these products are not namespaced and have generic names. The code-generator product, `protoc-gen-grpc-swift`, appears to be the only executable intended for export and it is already appropriately namespaced. Modifications: Unexport the executable products that are not intended for use by clients. Change the `Makefile` to reference the executable targets rather than their derived products. Result: Fewer potential namespace conflicts. This fixed grpc#591.
glbrntt
approved these changes
Sep 26, 2019
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Sep 26, 2019
Motivation: 60205ad (grpc#592) cleared up the product namespace by removing executables which were not meant to be exposed to clients. However the post-merge CI failed (i.e. interop tests) because the executable targets no longer exist. This was missed because the CI for the PR was still able to build the targets and because the products had different names to the targets. Modifications: Use 'swift run' in the CI script used after merging PRs. Result: Interop tests should be runnable when a PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
From https://developer.apple.com/documentation/swift_packages/product
Several executable products are not meant to be made available to
clients, but rather exist for internal integration or performance tests.
Further, most of these products are not namespaced and have generic names.
The code-generator product,
protoc-gen-grpc-swift, appears to be theonly executable intended for export and it is already appropriately
namespaced.
Modifications:
Unexport the executable products that are not intended for use by clients.
Change the
Makefileto reference the executable targets rather than theirderived products.
Result:
Fewer potential namespace conflicts. This fixed #591.