Use "swift run" for interop tests in CI #593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 60205ad (grpc#592) cleared up the product namespace by removing executables which were not meant to be exposed to clients. However the post-merge CI failed (i.e. interop tests) because the executable targets no longer exist. This was missed because the CI for the PR was still able to build the targets and because the products had different names to the targets. Modifications: Use 'swift run' in the CI script used after merging PRs. Result: Interop tests should be runnable when a PR is merged.
|
|
Collaborator
Author
|
@kevints I'm unable to request your review for this but please do so! |
Contributor
|
Looks like this is a package manager bug, filed https://bugs.swift.org/browse/SR-11528 As a workaround, can the main build run |
Collaborator
Author
|
Closing in favour of: #596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
60205ad (#592) cleared up the product namespace by removing executables
which were not meant to be exposed to clients. However the post-merge CI
failed (i.e. interop tests) because the executable targets no longer
exist. This was missed because the CI for the PR was still able to build
the targets and because the products had different names to the targets.
Modifications:
Use 'swift run' in the CI script used after merging PRs.
Result:
Interop tests should be runnable when a PR is merged.