Add a server builder #752
Merged
Add a server builder #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Configuring a server with err... `Configuration` can be a bit unwieldy and makes it easy for users to not use TLS. It's also a slight SemVer burden since we'd want to add a new `init` each time we add a member. Modifications: - Add a `Server.Builder` - Replace existing use of `Server.Configuration` with the builder - Update docs Result: - Server starting API is nicer - You have to type `insecure` to not use TLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Configuring a server with err...
Configurationcan be a bit unwieldyand makes it easy for users to not use TLS. It's also a slight SemVer burden
since we'd want to add a new
initeach time we add a member.Modifications:
Server.BuilderServer.Configurationwith the builderResult:
insecureto not use TLS