Log errors from the server channel. #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Lukasa
force-pushed
the
cb-logging-on-initializer-failure
branch
from
2d9cdc6 to
392b2bd
Compare
glbrntt
requested changes
May 13, 2020
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Looks great, but you need to run swift test --generate-linuxmain I'm afraid
Motivation: When the child channel initializer fails, or if any part of child channel setup fails, the error that results is not thrown into that child channel but is instead propagated into the server channel. As nothing in grpc was listening for errors there, those errors got lost. This can make some problems particularly tricky to debug, as they lead to silent service failures. Modifications: - Added a channel handler to be put in all server channels. Results: Server channel creation errors now get propagated into the error delegate.
Lukasa
force-pushed
the
cb-logging-on-initializer-failure
branch
from
392b2bd to
6696840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the child channel initializer fails, or if any part of child
channel setup fails, the error that results is not thrown into that
child channel but is instead propagated into the server channel. As
nothing in grpc was listening for errors there, those errors got lost.
This can make some problems particularly tricky to debug, as they lead
to silent service failures.
Modifications:
Results:
Server channel creation errors now get propagated into the error
delegate.