Provide conformance for messages provided by SwiftProtobuf #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We currently generate conformance to `GRPCProtobufPayload` based on the input and output types of `rpc`s defined in .proto files passed to the plugin. This works in some situations, including when the .proto file for the message in question is not present (such as those provided by the SwiftProtobuf library; `Google_Protobuf_*`). However this is problematic if the plugin is invoked on a file-by-file basis where each file contains the message since the conformance would be erroneously generated mulutple times. Modifications: - Provide conformance to all `Google_Protobuf_*` messages currently vendored by `SwiftProtobuf` - Generaate conformance only based on the `message`s defined in each .proto file - Add a few generation tests Result: Multiple conformance generation is avoided in the scenario set out above.
Collaborator
Author
|
Resolves #801 |
Lukasa
approved these changes
May 26, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We currently generate conformance to
GRPCProtobufPayloadbased on theinput and output types of
rpcs defined in .proto files passed to theplugin. This works in some situations, including when the .proto file
for the message in question is not present (such as those provided by
the SwiftProtobuf library;
Google_Protobuf_*). However this isproblematic if the plugin is invoked on a file-by-file basis where each
file contains the message since the conformance would be erroneously
generated mulutple times.
Modifications:
Google_Protobuf_*messages currentlyvendored by
SwiftProtobufmessages defined in each.proto file
Result:
Multiple conformance generation is avoided in the scenario set out
above.