Add a server-idle handler #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
gb-server-idle-timeout
branch
2 times, most recently
from
472cac0 to
f75b1c4
Compare
Motivation: Connections should be dropped to save resources if there are not RPCs for an idle timeout. This was added for clients in grpc#798; this adds similart functionality to the server. Modifications: - Rename a `ClientConnectivityHandler` to `GRPCIdleHandler` - Add a 'mode' to the idle handler Note: timeout configuration will be added for client and server in a followup PR. Result: - Server's will drop connections if the client isn't doing anything. - Resolves grpc#706
glbrntt
force-pushed
the
gb-server-idle-timeout
branch
from
f75b1c4 to
4c804d4
Compare
Collaborator
Author
|
ping @Lukasa |
Lukasa
approved these changes
Jun 3, 2020
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
This looks awesome, the refactoring has made this really nice. 
:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Connections should be dropped to save resources if there are not RPCs
for an idle timeout. This was added for clients in #798; this adds
similart functionality to the server.
Modifications:
GRPCServerIdleHandlerto drop connections after 5 minutes ofno RPCs
Note: timeout configuration will be added for client and server in a
followup PR.
Result: