Add 'isOk' to GRPCStatus #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `GRPCStatus` has a static `.ok` status which is useful when implementing service providers. However, since the status also includes a message it's too easy for someone receiving a status to check `status == .ok` where they really mean 'status.code == .ok'. Modifications: - Add a convenience `.isOk` to `GRPCStatus` - Add a note to `.ok` Result: - Slightly reduced chance of user error. - Resolves grpc#821
Collaborator
|
LGTM; we could still consider to make |
Collaborator
Author
|
I think this is probably sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
GRPCStatushas a static.okstatus which is useful when implementingservice providers. However, since the status also includes a message it's
too easy for someone receiving a status to check
status == .okwherethey really mean 'status.code == .ok'.
Modifications:
.isOktoGRPCStatus.okResult: