Allow deadlines or timeouts to be set on RPCs #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Sometimes timeouts are useful, other times deadlines are useful. We should support both. Modifications: - Add a `timeLimit` to `CallOptions`, which is essentially a deadline or a timeout. When we start a call we generate a deadline from the time limit and forward that timeline through the pipeline and then compute a timeout to send to the server. - For timeouts, `GRPCTimeout` has been replaced by `TimeAmount`, the user doesn't care how the timeout is serialized over the wire so it makes more sense to use a type which provides better interoperability with the rest of the community. - Shims for deprecating `CallOptions(timeout:)` Result: - Users can set timeouts or deadlines - Better deadline/timeout interoperability with other NIO applications
Collaborator
Author
|
Hmm GitHub says CI is pending but Travis says it's completed and passed. I'll believe Travis here; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes timeouts are useful, other times deadlines are useful. We
should support both.
Modifications:
timeLimittoCallOptions, which is essentially a deadline ora timeout. When we start a call we generate a deadline from the time
limit and forward that timeline through the pipeline and then compute
a timeout to send to the server.
GRPCTimeouthas been replaced byTimeAmount, theuser doesn't care how the timeout is serialized over the wire so it
makes more sense to use a type which provides better interoperability
with the rest of the community. Most of the
GRPCTimeoutcode hasbeen relocated to shims and marked as deprecated.
CallOptions(timeout:)Result: