Stop sending requests in call init #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Previously @Lukasa noted that we did some networking in the call init's which isn't ideal. I forgot that calls are made though an internal class, so it is indeed possible to move the networking calls. Modifications: - Move networking calls to just after the call object is created - Shuffling code about, no real functional changes Result: - No networking in the *Call inits - Cleaner inits - Nothing functional
Lukasa
reviewed
Jun 18, 2020
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
You made transport public on your 4 call objects so that the connection objects can invoke it. Would it be better to keep it private and instead have the call objects implement that method, and then just call it on their private object?
Collaborator
Author
100%. Will update, thanks. |
Lukasa
approved these changes
Jun 24, 2020
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Fantastic, I like this patch a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously @Lukasa noted that we did some networking in the call init's
which isn't ideal. I forgot that calls are made though an internal
class, so it is indeed possible to move the networking calls.
Modifications:
Result: