Provide errors to failed client promises rather than a status #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If an RPC fails for some reason we will convert the error into an appropriate `GRPCStatus`. This status is used to succeed the status promise and fail any other promises (initial and trailing metadata, and if applicable, the response promise). Without looking at logs it's harder to determine the exact nature of the error. Modifications: - Fail the initial metadata, trailing metadata and response promise with the error that the status was derived from. Result: More helpful errors.
glbrntt
force-pushed
the
gb-better-errors
branch
from
4cf5802 to
bb9f57b
Compare
Lukasa
approved these changes
Jun 25, 2020
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
This looks like a really good addition, I like it a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If an RPC fails for some reason we will convert the error into an
appropriate
GRPCStatus. This status is used to succeed the statuspromise and fail any other promises (initial and trailing metadata, and
if applicable, the response promise). Without looking at logs it's
harder to determine the exact nature of the error.
Modifications:
the error that the status was derived from.
Result:
More helpful errors.