Add back GRPCPayload support for server handlers #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Recent work in grpc#886 and grpc#889 made `GRPCProtobufPayload` redundant. Since we broke this work into multiple PRs we temporarily dropped support for custom `GRPCPayload`s on the server. This PR adds that back. Modifications: - Add `GRPCPayload` support back to the server by adding the relevant call handler factory functions - Re-enable the custom payload tests - Add a few more custom payload tests (since they were limited to just bidirectional streaming) Result: - Clients and servers support `SwiftProtobuf.Message` and `GRPCPayload` separately without using `GRPCProtobufPayload` to bridge between them.
Lukasa
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Recent work in #886 and #889 made
GRPCProtobufPayloadredundant. Sincewe broke this work into multiple PRs we temporarily dropped support for
custom
GRPCPayloads on the server. This PR adds that back.Modifications:
GRPCPayloadsupport back to the server by adding the relevantcall handler factory functions
bidirectional streaming)
Result:
SwiftProtobuf.MessageandGRPCPayloadseparately without using
GRPCProtobufPayloadto bridge between them.