Add a 'preflight check' stage to CI #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
gb-preflight
branch
7 times, most recently
from
15d0354 to
f9b1901
Compare
Motivation: Often contributors miss out license checks, have formatting issues or haven't generated linux tests. Let's bring these checks up front and make sure they're done before we run any tests. Modifications: - Add a "Preflight Checks" stage to CI - Add a sanity script which currently just checks license headers; we can add other checks later. Note that in CI this is called via .travis-script.sh as it sets up the environment (setting up PATH etc.t) - Add building and caching SwiftFormat to the install step, it's not used yet but will be later. - Fix a bunch of shellcheck issues - Replaces some travis environment variables with flags Result: - We have a way to check non-code related things before checking functional changes
Lukasa
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Often contributors miss out license checks, have formatting issues or
haven't generated linux tests. Let's bring these checks up front and
make sure they're done before we run any tests.
Modifications:
can add other checks later.
Result:
functional changes