Fix a few incorrect source locations in logs #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: swift-log 1.3.0 introduced a new concepct: the source of a log. This identifies the creator of the emitted log, typically the module or system that emitted the log. The default value is currently (meant to be) the module name. This is found by parsing the '#file' to find the directory the file is contained in. However, this isn't always the module. Modifications: - Capture the log source in tests - Validate the source in test tear down - Fix up incorrect sources Result: - gRPC more uniformly emits a useful log source
Lukasa
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-log 1.3.0 introduced a new concepct: the source of a log. This
identifies the creator of the emitted log, typically the module or
system that emitted the log.
The default value is currently (meant to be) the module name. This is
found by parsing the '#file' to find the directory the file is
contained in. However, this isn't always the module.
Modifications:
Result: