Avoid unnecessary arrays. #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
force-pushed
the
cb-avoid-allocating-arrays
branch
2 times, most recently
from
9c51548 to
ea4b679
Compare
glbrntt
approved these changes
Aug 12, 2020
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Looks great but you also need to update the test manifests...? (I need to bring this forward as part of the sanity check)
Motivation: HTTP1ToGRPCServerCodec currently creates a temporary array for parsing all messages into before it forwards them on. This is both a minor perf drain (due to the extra allocations) and a correctness problem, as it makes this channel handler non-reentrant-safe. We should fix both issues. Modifications: - Replace the temporary array with a simple loop. - Add tests that validates correct behaviour on reentrancy. Result: Better re-entrancy behaviour! Verrrry slightly better perf.
Lukasa
force-pushed
the
cb-avoid-allocating-arrays
branch
from
ea4b679 to
302209f
Compare
Collaborator
Author
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HTTP1ToGRPCServerCodec currently creates a temporary array for parsing
all messages into before it forwards them on. This is both a minor perf
drain (due to the extra allocations) and a correctness problem, as it
makes this channel handler non-reentrant-safe. We should fix both
issues.
Modifications:
Result:
Better re-entrancy behaviour! Verrrry slightly better perf.