Log some HTTP/2 information #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Aug 14, 2020
| handler: @escaping (Deserializer.Output) -> Void | ||
| ) -> BidirectionalStreamingCall<Serializer.Input, Deserializer.Output> { | ||
| let (logger, requestID) = self.populatedLoggerAndRequestID(from: callOptions) | ||
| logger.debug("starting rpc", metadata: ["path": "\(path)"]) |
Collaborator
There was a problem hiding this comment.
Is the theory we don't need these anymore?
Collaborator
Author
There was a problem hiding this comment.
These are duplicates.
glbrntt
force-pushed
the
gb-more-logging
branch
from
f39538f to
d242625
Compare
Motivation: Sometimes it's useful to know what's going on at the HTTP/2 layer, none of our logs currently surface this information. Modifications: - Add logs for stream created/closed events (includes open stream count) - Add logs for initial settings - Add more logging for connection lifecycle - Add trace logs to the stream for read/written frames - Prefix request and connection ID metadata keys with "grpc_" - Remove duplicated log messages Result: - Better insight for HTTP/2
glbrntt
force-pushed
the
gb-more-logging
branch
from
d242625 to
919f272
Compare
Lukasa
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes it's useful to know what's going on at the HTTP/2 layer, none
of our logs currently surface this information.
Modifications:
Result: