Import SwiftProtobuf in generated code #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Aug 24, 2020
Motivation: Generated code may rely on messages which ship with SwiftProtobuf, as such we should always import SwiftProtobuf. Modifications: - Import SwiftProtobuf in codegen Result: Resolves grpc#951
glbrntt
force-pushed
the
gb-import-protobuf
branch
from
4c36a10 to
c1d892a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Generated code may rely on messages which ship with SwiftProtobuf, as
such we should always import SwiftProtobuf.
Modifications:
Result:
Resolves #951