Update the connection ID on transient failures #969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The logger for the connection mananger includes some metadata for the connection ID, and the connection mananger is willing to append that metadata to any logger provided to it. The ID is a UUID suffixed with a monotonically increasing number. The suffix is incremented after the connection has become idle so that new channels have a unique but related ID. However, if a connection is dropped the connection manager will attempt to re-establish it yet the suffix will not change. This is quite misleading in logs since the underlying channel will have changed. Modifications: - Increment the connection number when transitioning to transient failure Result: - The connection ID is incremented when the underlying channel will change
Lukasa
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The logger for the connection mananger includes some metadata for the
connection ID, and the connection mananger is willing to append that
metadata to any logger provided to it.
The ID is a UUID suffixed with a monotonically increasing
number. The suffix is incremented after the connection has become idle
so that new channels have a unique but related ID. However, if a
connection is dropped the connection manager will attempt to
re-establish it yet the suffix will not change. This is quite
misleading in logs since the underlying channel will have changed.
Modifications:
failure
Result:
change