Skip to content
This repository was archived by the owner on Apr 9, 2021. It is now read-only.

Update installation instructions in C++ quickstart.#713

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
fdasoghe:patch-1
Aug 13, 2018
Merged

Update installation instructions in C++ quickstart.#713
jtattermusch merged 1 commit intogrpc:masterfrom
fdasoghe:patch-1

Conversation

@fdasoghe
Copy link
Copy Markdown

Starting from scratch and following all proposed steps on Linux leads to an incomplete setup: it's missing the install command for gRPC compiled from source.
I've added it in the main C++ quick start document.

@thelinuxfoundation
Copy link
Copy Markdown

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@fdasoghe
Copy link
Copy Markdown
Author

I've submitted the CCLA request.

@carl-mastrangelo
Copy link
Copy Markdown

cc: @nicolasnoble

Comment thread docs/quickstart/cpp.md Outdated
@@ -19,6 +19,11 @@ working example.</p>
To install gRPC on your system, follow the [instructions to build from
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding more instructions in this doc, we should point to https://github.com/grpc/grpc/tree/master/src/cpp#make instead, which has the info about how to install with different build systems (and links to the building.md doc too).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you're suggesting to insert the link you showed in place of the one already present? Or as an additional pointer?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically wanted to replace the existing link. I've done so in this PR and I'm going to merge.

@carl-mastrangelo
Copy link
Copy Markdown

@think01 Hi, we are currently talking with the owners of the CLA bot, did you ever get the confirmation email?

@fdasoghe
Copy link
Copy Markdown
Author

@carl-mastrangelo sorry no, I didn't receive a confirmation about the CLA (I have some mails about changing password and confirming the email address, but I think they're not what you're asking about).

@jtattermusch jtattermusch changed the title Following exact steps proposed lead to error Update installation instructions in C++ quickstart. Aug 13, 2018
Copy link
Copy Markdown

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtattermusch jtattermusch merged commit eafa32d into grpc:master Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants