Update installation instructions in C++ quickstart.#713
Update installation instructions in C++ quickstart.#713jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
I've submitted the CCLA request. |
|
cc: @nicolasnoble |
| @@ -19,6 +19,11 @@ working example.</p> | |||
| To install gRPC on your system, follow the [instructions to build from | |||
There was a problem hiding this comment.
instead of adding more instructions in this doc, we should point to https://github.com/grpc/grpc/tree/master/src/cpp#make instead, which has the info about how to install with different build systems (and links to the building.md doc too).
There was a problem hiding this comment.
Then you're suggesting to insert the link you showed in place of the one already present? Or as an additional pointer?
There was a problem hiding this comment.
I basically wanted to replace the existing link. I've done so in this PR and I'm going to merge.
|
@think01 Hi, we are currently talking with the owners of the CLA bot, did you ever get the confirmation email? |
|
@carl-mastrangelo sorry no, I didn't receive a confirmation about the CLA (I have some mails about changing password and confirming the email address, but I think they're not what you're asking about). |
Starting from scratch and following all proposed steps on Linux leads to an incomplete setup: it's missing the install command for gRPC compiled from source.
I've added it in the main C++ quick start document.