This repository was archived by the owner on Apr 9, 2021. It is now read-only.
gRPC Web GA announcement blog post#765
Merged
hsaliak merged 3 commits intogrpc:masterfrom Oct 24, 2018
Merged
Conversation
stanley-cheung
approved these changes
Oct 21, 2018
| auto generated. To do this, you have a choice between the [Closure](https://developers.google.com/closure/compiler/) compiler | ||
| or the more widely used [CommonJS](https://requirejs.org/docs/commonjs.html). | ||
| This development process removes the need to manage concerns such as creating | ||
| custom JSOn seralization and deserialization logic, wrangling HTTP status codes |
| ```proto | ||
| protoc echo.proto \ | ||
| --js_out=import_style=commonjs:./output \ | ||
| --grpc-web_out=import_style=commonjs:./output |
There was a problem hiding this comment.
does this need to be on the PATH, or is it built in to proto by default?
There was a problem hiding this comment.
--js_out is built into protoc. --grpc-web_out user has to compile by themselves. User has been able to follow these instructions - so we should be fine here.
carl-mastrangelo
approved these changes
Oct 23, 2018
| var metadata = {}; | ||
| var getTodo = todoService.getTodoById(getTodoRequest, metadata, (err, response) => { | ||
| if (err) { | ||
| console.log(err); |
There was a problem hiding this comment.
Convention is usually just console.log for everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the post for gRPC-Web GA. PTAL.
/cc @lucperkins
I am targeting to publish this on Tuesday 23rd Oct.