.NET SDK integration post, NuGet v1.17#775
.NET SDK integration post, NuGet v1.17#775jtattermusch merged 5 commits intogrpc:masterfrom kkm000:kkm/grpc-dotnet-build
Conversation
carl-mastrangelo
left a comment
There was a problem hiding this comment.
@kkm000 Looks cool, I did a brief pass over it. Please ping this if it isn't getting attention.
| drwxrwxr-x 2 kkm kkm 4096 Nov 9 16:10 obj/ | ||
| ``` | ||
|
|
||
| The `dotnet new` command has created the file `Class1.cs` that we won't need, so |
There was a problem hiding this comment.
Nit: it's easier to read if the verb tenses align throughout. Consider rewording this "The dotnew new command creates the file ...".
There was a problem hiding this comment.
I rephrased that sentence a bit, but I am not sure I grok your concern. This is as present a tense as it only could be.
hsaliak
left a comment
There was a problem hiding this comment.
This looks great, thanks for writing it up! left a few minor comments
| <PackageReference Include="Google.Protobuf" Version="3.6.1" /> | ||
| <PackageReference Include="Grpc" Version="1.17.0" /> | ||
| <PackageReference Include="Grpc.Tools" Version="1.17.0" PrivateAssets="All" /> | ||
| <ProtoBuf Include="helloworld.proto" /> |
There was a problem hiding this comment.
nit: put the tag under a separate ? That would make it more visible and it's also the style that Visual Studio would use if you added a file through the IDE.
There was a problem hiding this comment.
Come think of it, I'm rather inclined against this.
My thinking goes, I do not know if user's editor supports XML, and XML is nasty to type without syntax highlighting and checking from the editor. So I think for the purposes of the throwaway walkthrough this is good enough. The goal as I understand it is to make the walkthrough as smooth as possible, and XML brockets are braindead. By me, the fewer, the better.
Some people prefer to keep it neat, others just lump it all together. And MSBuild does not care.
|
In summary, I added a 2nd paragraph from the top, above the more marker, to explain the intent better, another paragraph on dependency checking, and one sentence st the very end--it sounded to me as if it was lacking a nice closing. Thanks for the comments everyone! Ready for the round 2! @jtattermusch, this should not be published before the example branch is merged, I guess? |
|
@kkm000 yes this will only be published once 1.17.0 packages are out, so that the feature can be easily tried by everyone. |
| <ItemGroup> | ||
| <PackageReference Include="Google.Protobuf" Version="3.6.1" /> | ||
| <PackageReference Include="Grpc" Version="1.17.0" /> | ||
| <!-- Add attribute as shown below. --> |
There was a problem hiding this comment.
nit: at the first sight the indent looks like it's done by mistake. Also let's make the comment more informative.
<!-- mark Grpc.Tools as build-only dependency by adding PrivateAssets="All" attribute -->
There was a problem hiding this comment.
Done, does this read better? Not really sure if the shouty-cased "IMPORTANT" is appropriate.
jtattermusch
left a comment
There was a problem hiding this comment.
I think the blogpost is looking good, thanks for writing it!
I'll merge (and publish the blogpost) once the v1.17.0 release is out, nugets are pushed and the examples PR is merged.
|
Super, thank you! |
|
This post will tentatively go out tomorrow. @kkm000, would you be able to rename the post to 12-18-18 so that it appears as the newest post on the https://grpc.io/blog/ list? |
|
@carl-mastrangelo Done. |
|
Let's merge? |
|
Things are looking good, so I'll go ahead and merge. |
|
Looks weird, no heading or the pre-cut paragraphs. Is there some indexing that has to happen, or is something wrong with formatting? |
|
Just realized, this: https://github.com/grpc/grpc.github.io/blob/master/_posts/2018-18-18-grpc-dotnet-build.md shows the keywords as a block, but this https://github.com/grpc/grpc.github.io/blob/master/_posts/2018-12-11-grpc-stacks.md as table. The parser does not like something. Quotes around |
|
Good catch, do you wanna create a PR to replace |
|
Here is a couple of solutions, trying both. Quotes seem less ugly that the hex code. Just a sec. |
|
@jtattermusch, #798. Looks like a table, similar to other .ms files. |
This is a post announcing integrated build of proto files in a C# .NET projects, upcoming in v1.17.
I hope I matched both the general philosophy and tone of the blog, but I'd be happy to make any corrections.
/cc @jtattermusch